Skip to content

Add mssql support and minimal fast tests scenarios for DBs#12

Open
MaximilianJahns wants to merge 8 commits into
green-coding-solutions:mainfrom
MaximilianJahns:main
Open

Add mssql support and minimal fast tests scenarios for DBs#12
MaximilianJahns wants to merge 8 commits into
green-coding-solutions:mainfrom
MaximilianJahns:main

Conversation

@MaximilianJahns

Copy link
Copy Markdown

No description provided.

@ArneTR

ArneTR commented May 8, 2026

Copy link
Copy Markdown
Member

Hey @MaximilianJahns

Thanks for opening the PR here.

For me the state of this PR is very hard to understand due to multiple issues:

  • There is no description of what the PR does actually. I understand that it adds benchmarks, but you also changed a lot of other stuff
  • Please split up the PRs into separate ones addressing one core thing at a time
    • Every DB in one PR
    • Bigger Structural changes in one PR
      The reason for the pendantic-ness here is that we can actually use tools to review the PR (coderabbit), which would flake with such big contexts. Furthermore for me as a human it is also better actually smaller PRs
  • You introduced production and test. What is the difference? Is both needed?
  • There are stray files. What is Readme.save?

@MaximilianJahns

Copy link
Copy Markdown
Author

hey yes you are rigth. i will delete the test folder for the repro, its is just good for developing or creating minimal testcases that doesnt run for minutes. but they are not needed in general.... i will splitt each db in a pr.

@ribalba

ribalba commented May 12, 2026

Copy link
Copy Markdown
Member

If I read this correctly this PR has been split up and can be losed?

@ArneTR

ArneTR commented May 13, 2026

Copy link
Copy Markdown
Member

@MaximilianJahns The last removes the SCI. Please do not do that but migrate it to the new format. See here: https://docs.green-coding.io/docs/measuring/carbon/sci/

Furthermore you commited a big file which seems unrelated to anything in this repository ... looks like a debug file? What is the purpose of that that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants