Add mssql support and minimal fast tests scenarios for DBs#12
Open
MaximilianJahns wants to merge 8 commits into
Open
Add mssql support and minimal fast tests scenarios for DBs#12MaximilianJahns wants to merge 8 commits into
MaximilianJahns wants to merge 8 commits into
Conversation
added 6 commits
May 6, 2026 15:53
Member
|
Hey @MaximilianJahns Thanks for opening the PR here. For me the state of this PR is very hard to understand due to multiple issues:
|
Author
|
hey yes you are rigth. i will delete the test folder for the repro, its is just good for developing or creating minimal testcases that doesnt run for minutes. but they are not needed in general.... i will splitt each db in a pr. |
Member
|
If I read this correctly this PR has been split up and can be losed? |
Member
|
@MaximilianJahns The last removes the SCI. Please do not do that but migrate it to the new format. See here: https://docs.green-coding.io/docs/measuring/carbon/sci/ Furthermore you commited a big file which seems unrelated to anything in this repository ... looks like a debug file? What is the purpose of that that ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.